Re: [patch, -git] pcie hotplug bootup crash fix

[Kenji Kaneshige]

Andrew Morton wrote:
> On Mon, 26 May 2008 10:47:09 +0200 Ingo Molnar <mingo@xxxxxxx> wrote:
>
> > * Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx> wrote:
> >
> > > I updated Ingo's patch. If it's ok, I'll send it to Jess Barnes with 
> > > some other patches for the other pciehp regression problems.
> > looks good to me, thanks Kenji.
>
> It's a bit sad to add a large workaround like this.  I'm surprised
> that fixing it properly is considered unviable for 2.6.26.  Normally
> these fixes are pretty simple - just request the IRQ a bit later?

Although I have not considered how to implement proper fix deeply,
I don't think it's so simple. For example, current pciehp is doing
like this:

(1) some initialization
(2) request_irq()
(3) issue command
(4) initialize slot data structure

Maybe we want to do (2) after (4) to fix the problem. But if we
simply move (2) after (4), we cannot detect the command completion
event at (3) and it will cause command timeout.

It's just an example, and there might be other things like this.
This example might be fixed simply, but all my worry is that fixing
this quickly might cause another regressions. This is why I think
Ingo's approach is better in a short term.

And another reason is I'm very nervous because I already caused
many problems in pciehp since 2.6.26-rcX... :(

Thanks,
Kenji Kaneshige




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/