Re: rtc-cmos.c: Build fix

From: Andrew Morton
Date: Wed May 07 2008 - 17:31:54 EST


On Tue, 6 May 2008 15:51:25 -0300
"Carlos R. Mafra" <crmafra2@xxxxxxxxx> wrote:

> Subject: [PATCH] rtc-cmos.c: Build fix
>
> The function hpet_rtc_interrupt(..) is to be used only if CONFIG_HPET_EMULATE_RTC
> is defined (see arch/x86/kernel/hpet.c), so we define it to return 0 when
> !CONFIG_HPET_EMULATE_RTC to avoid build failures.
>
> This function will never be used anyways when !CONFIG_HPET_EMULATE_RTC because
> it is inside a if(is_hpet_enabled()) which is never true when
> !CONFIG_HPET_EMULATE_RTC.

I've lost the plot on this one. Could we please have a description of
the problem which is being fixed? ie, the compiler (or linker?) output,
and a description of why it is occurring?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/