Re: [PATCH] bay: Exit if notify handler cannot be installed

From: Henrique de Moraes Holschuh
Date: Tue May 06 2008 - 21:14:20 EST


On Wed, 07 May 2008, Shaohua Li wrote:
> On Tue, 2008-05-06 at 12:18 -0300, Henrique de Moraes Holschuh wrote:
> > On Tue, 06 May 2008, Shaohua Li wrote:
> > > The bay driver is duplicated with libata, I thought we should delete it.
> > > See bug http://bugzilla.kernel.org/show_bug.cgi?id=9526
> >
> > The bay driver is currently useless, BUT it should handle a lot of stuff
> > libata won't, such as bay batteries, bay floppies, and anything else in
> > a bay that is not a hard disk.
> >
> > The fact that the driver currently looks only after disks is just a bug.
> > It should, in fact, bind to any ejectable device not already handled by
> > a different driver.
> Isn't this the job of acpi dock driver?

No, but I actually fail to see why do we even care about the difference
from a dock to a bay. Dock *could* be made to handle both.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/