Re: [PATCH 08/18] flag parameters: epoll_create

[Davide Libenzi]

On Wed, 7 May 2008, Michael Kerrisk wrote:

> On Wed, May 7, 2008 at 12:41 AM, Davide Libenzi <davidel@xxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, 6 May 2008, Matthew Helsley wrote:
> >
> > >
> > > On Sun, 2008-05-04 at 23:42 -0400, Ulrich Drepper wrote:
> > > > This patch adds the new epoll_create2 syscall.  It extends the old epoll_create
> > > > syscall by one parameter which is meant to hold a flag value.  In this
> > > > patch the only flag support is EPOLL_CLOEXEC which causes the close-on-exec
> > > > flag for the returned file descriptor to be set.
> > >
> > > Davide, Ulrich,
> > >
> > >       A minor question: Why did you choose to pass the seemingly useless
> > > "size" parameter into the new epoll_create2 system call? I did some
> > > googling for previous threads with this series and couldn't find a
> > > discussion on why you chose to keep it.
> >
> > The very first implementations were using an hash, and that was a size
> > hint.
> 
> So, why not simply remove this argument in the new API, since it is now useless?

I'm more than OK with that.



- Davide


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/