Re: x86: Unify current.h

From: Ingo Molnar
Date: Tue May 06 2008 - 08:51:59 EST



* Ingo Molnar <mingo@xxxxxxx> wrote:

>
> * Christoph Lameter <clameter@xxxxxxx> wrote:
>
> > There are just two definitions that are shared but the resulting
> > combined file is resonably small. Putting these two arch headers
> > together shows that further unifications requires a unification of the
> > per cpu / pda handling between both arches (zero based or some
> > variation thereof).
> >
> > Signed-off-by: Christoph Lameter <clameter@xxxxxxx>
>
> applied, thanks Christoph.

x86.git testing found a build failure due to this patch:

include/asm/current.h: Assembler messages:
include/asm/current.h:4: Error: no such instruction: `struct task_struct'

with this config:

http://redhat.com/~mingo/misc/config-Tue_May__6_14_45_51_CEST_2008.bad

i suspect the __ASSEMBLY__ protections in the unified file are not wide
enough?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/