Re: [rfc] the kernel workflow & trivial "global -> static" patches(was: Re: [2.6 patch] make sched_feat_{names,open} static)

From: Adrian Bunk
Date: Mon May 05 2008 - 17:08:31 EST


On Mon, May 05, 2008 at 01:42:52PM -0700, Andrew Morton wrote:
> On Mon, 5 May 2008 22:19:06 +0200
> Ingo Molnar <mingo@xxxxxxx> wrote:
>
> > Firstly, the practical problem: today "make namespacecheck" emits way
> > too many false positives even on an allyesconfig build
>
> We don't actually care about what comes out of `make namespacecheck'. We
> care about the _difference_ in its output when a patch is applied.
>
> So a script which reports on what changes a particular patch has upon
> namespacecheck output might be the way to go. If it is fast enough then it
> can be run on a per-patch basis alongside checkpatch.

"make namespacecheck" works on the binary objects.

- touching header files can result in a complete rebuild
- if a patch alters which objects get built you should start with
a clean object dir

The question is therefore basically whether a complete rebuild of an
all*config kernel is fast enough for you...

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/