Re: [PATCH] capabilities: add bounding set to /proc/self/status

[Andrew Morton]

On Mon, 5 May 2008 10:22:06 +0200 "Michael Kerrisk" <mtk.manpages@xxxxxxxxxxxxxx> wrote:

> On Fri, May 2, 2008 at 2:38 AM, Chris Wright <chrisw@xxxxxxxxxxxx> wrote:
> > * Serge E. Hallyn (serue@xxxxxxxxxx) wrote:
> > > There is currently no way to query the bounding set of another
> > > task.  As there appears to be no security reason not to, and
> > > as Michael Kerrisk points out the following valid reasons to do
> > > so exist:
> > >
> > > * consistency (I can see all of the other per-thread/process sets in
> > > /proc/.../status)
> > > * debugging -- I could imagine that it would make the job of debugging
> > > an application that uses capabilities a little simpler.
> > >
> > > this patch adds the bounding set to /proc/self/status right after
> > > the effective set.
> > >
> > > If at all possible (and if acked by Andrew Morgan) it would be nice to
> > > get this into the 2.6.26 cycle.  But I realize it probably is too late
> > > for that.
> >
> > I've no issue with this.
> >
> > > Signed-off-by: Serge E. Hallyn <serue@xxxxxxxxxx>
> > > Acked-by: Michael Kerrisk <mtk.manpages@xxxxxxxxx>
> >
> > Acked-by: Chris Wright <chrisw@xxxxxxxxxxxx>
> >
> >
> > > ---
> > >  fs/proc/array.c |    1 +
> > >  1 files changed, 1 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/fs/proc/array.c b/fs/proc/array.c
> > > index c135cbd..160dd4a 100644
> > > --- a/fs/proc/array.c
> > > +++ b/fs/proc/array.c
> > > @@ -297,6 +297,7 @@ static inline void task_cap(struct seq_file *m, struct task_struct *p)
> > >       render_cap_t(m, "CapInh:\t", &p->cap_inheritable);
> > >       render_cap_t(m, "CapPrm:\t", &p->cap_permitted);
> > >       render_cap_t(m, "CapEff:\t", &p->cap_effective);
> > > +     render_cap_t(m, "CapBnd:\t", &p->cap_bset);
> > >  }
> > >
> > >  static inline void task_context_switch_counts(struct seq_file *m,
> >
>

[top-posting repaired]

> Andrew (Morgan),
> 
> It looks like this didn't make it into rc1, even though it was sent
> within the merge window -- perhaps Linus or Andrew (Morton) needed to
> be explicitly CCed?
> 

Sorry, I'm horridly backlogged.  I seem to be able to process them at about
105% of the arrival rate lately, so we'll get there.  It isn't lost.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/