Re: [patch 12/15] vfs: create file_truncate() helper

From: Miklos Szeredi
Date: Mon May 05 2008 - 08:36:20 EST


> On Mon, May 05, 2008 at 11:54:53AM +0200, Miklos Szeredi wrote:
> > From: Miklos Szeredi <mszeredi@xxxxxxx>
> >
> > Clean up do_truncate() API:
> >
> > - create a new function file_truncate()
> > - remove the 'struct file *' argument from do_truncate()
>
> file_truncate looks like a nice little cleanup, but please make sure to
> add a kerneldoc comment for every newly added global function.

OK.

> I don't think there's a point to remove the file argument from
> do_truncate and add another helper.

Whatever.

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/