Re: [PATCH 2/4] posix timers: sigqueue_free: don't free sigqueue ifit is queued

From: Linus Torvalds
Date: Sat May 03 2008 - 13:53:20 EST




On Sat, 3 May 2008, Oleg Nesterov wrote:
>
> Note: I am not sure we shouldn't do the opposite, free sigqueue + cancel the
> pending signal, but this needs some ugly changes. Perhaps we should reconsider
> this change later. See also http://bugzilla.kernel.org/show_bug.cgi?id=10460

You know what, I think there might be an even simple solution.

How about just setting a bit saying it is canceled - and nothing more.
Then, the dequeue logic can be just taught to ignore those things.

Doesn't that sound like the simple way to cancel signals? Make
collect_signal() just do a "return 0" if the signal has been flushed..

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/