Re: x86 git acpi issue?

From: Sam Ravnborg
Date: Sat May 03 2008 - 06:07:46 EST


On Sat, May 03, 2008 at 12:02:37PM +0200, Thomas Gleixner wrote:
> On Sat, 3 May 2008, Ingo Molnar wrote:
> > > Right. This Makefile is a nasty trap. I looked into it and the fix for
> > > now is below. Long term this Makefile trickery needs to be cleaned up
> > > to avoid trapping into this again.
> >
> > Thanks Thomas, i messed up that commit - i should have known that the
> > NUMAQ build fix looked _too_ easy ;-)
>
> Also the move of
> pci-$(CONFIG_ACPI) += acpi.o
> is what broke things.
>
> There is a nasty init function ordering problem as well between
>
> pci-$(CONFIG_ACPI) += acpi.o
> pci-y += legacy.o irq.o
>
> Sigh.

This is the kind of stuff that has prevented me from
unifying the two Makefiles.
But if no-one beats me I will give it a shot soon.
It will be a microsteps because we will likeky hit
such issues.

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/