Re: [PATCH] x86: mtrr cleanup for converting continuous to discrete- auto detect

From: Gabriel C
Date: Thu May 01 2008 - 20:30:25 EST


Yinghai Lu wrote:
> On Thu, May 1, 2008 at 4:45 AM, Gabriel C <nix.or.die@xxxxxxxxxxxxxx> wrote:
>> Yinghai Lu wrote:
>> > loop mtrr chunk_size and gran_size from 1M to 2G to find out optimal value.
>> >
>> > so user don't need to add mtrr_chunk_size and mtrr_gran_size,
>> >
>> > if optimal value is not found, print out all list to help select less optimal
>> > value.
>> >
>> > add mtrr_spare_reg_nr= so user could set 2 instead of 1, if the card need more entries.
>>
>> WOW :)
>>
>> With this patch all is working fine , no RAM is lost , X is fast ,
>> so far everything else seems to work fine. \o/
>>
>> I will test on 32bit tomorrow and stress the box later on today to be sure everything works fine.
>>
>> There is my dmesg , meminfo , mtrr output with this patch on top x86-latest :
>>
>> http://frugalware.org/~crazy/mtrr_x86-latest/
>
> while look at that you boot log, it seems there is one bug about hole
> position. but I look that code, it should already be handled.
>
> Can you send out boot msg and /proc/mtrr when using
> disable_mtrr_cleanup command line?

Sure , there it is :

http://frugalware.org/~crazy/mtrr_x86-latest/dmesg2
http://frugalware.org/~crazy/mtrr_x86-latest/proc_mtrr2

I'm still using this version of your patch , didn't got any time to update to v2.
If you want me to try v2 tell me , I have some free time in about 30 minutes.

>
> Thanks
>
> Yinghai Lu
>

Gabriel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/