Re: [PATCH] fix flags length in net 9p

From: Andrew Morton
Date: Thu May 01 2008 - 18:15:30 EST


On Thu, 1 May 2008 17:50:38 -0400 (EDT)
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

>
>
>
> > + typecheck(unsigned long, flags);

ooh, I'd forgotten about typecheck.

Just use typecheck. The BUILD_BUG_ON is overkill.

> We can simply have all users of flags use the new irqflags_t type, and
> just do a one time big patch (grant you, that would break all pending
> patches before that). But we can also write up a script that can convert
> patches as well.

y:/usr/src/linux-2.6.25> grep -rl 'unsigned long flags' . | wc -l
2311

eargh. I agree with me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/