Re: [PATCH] clocksource: shift helper

[Ralf Baechle]

On Thu, May 01, 2008 at 12:48:25PM -0700, Daniel Walker wrote:

> > If we expect this to have more than one callsite then it would be best to
> > uninline it.
> > 
> > Unless we always expect it to be called from __init code, in which case
> > it's best to inline it ;)
> 
> I expect it would always get called from __init flagged functions. The
> clocksource can't get registed/used with out the shift and mult values. 
> 
> If we did uninline this one, we would have to do the other helpers too.
> I imagine the use case is the same for all of them ..

I could imagine this being called for hotpluggable CPUs or nodes, so rather
__cpuinit than __init.

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/