Re: [PATCH] iTCO_wdt: ICH9DO support

From: Andrew Morton
Date: Wed Apr 30 2008 - 15:47:44 EST


On Wed, 30 Apr 2008 20:24:35 +0200
Gabriel C <nix.or.die@xxxxxxxxxxxxxx> wrote:

> Andrew Morton wrote:
> > On Wed, 30 Apr 2008 16:51:10 +0200
> > Gabriel C <nix.or.die@xxxxxxxxxxxxxx> wrote:
> >
> >> -#define DRV_VERSION "1.02"
> >> -#define DRV_RELDATE "26-Jul-2007"
> >> +#define DRV_VERSION "1.03"
> >> +#define DRV_RELDATE "30-Apr-2008"
> >
> > lol. git-watchdog changes these to
> >
> > #define DRV_VERSION "1.10"
> > #define DRV_RELDATE "17-Aug-2007"
> >
> > Version numbers and dates like this really are pretty pointless. If you
> > get a report against "v1.10", it just is not useful information. You still
> > need to ask "what kernel version" to be able to reliably locate the source
> > for the reporter's driver.
> >
> >
> > But it's a great way to generate .rej files.
>
> Really sorry Andrew here the patch without the changes to the driver version.
>

Is OK, I already fixed it (as you saw).

There's nothing to be sorry about - it's not your fault. My email can be
summarised down to "Hey, Wim: remove that crap!".

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/