Re: 2.6.25 new perfmon kernel patch + libpfm + pfmon available

From: Arjan van de Ven
Date: Wed Apr 30 2008 - 10:42:41 EST


On Wed, 30 Apr 2008 15:51:39 +0200
"stephane eranian" <eranian@xxxxxxxxxxxxxx> wrote:

> If I recall, AMD said that this special initialization would
> eventually migrate into the core kernel. The pci_read() may be there
> because it was not exported by the kernel (this particular code lives
> in a kernel module).

... yet your patch adds an EXPORT_SYMBOL() just to make this specific function possible. Weird.

I find it hard to believe that there would be no code in the kernel to
read or write config space of a device you have..... :)
In fact I bet 80% of the drivers in the tree use it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/