Re: [git pull] generic bitops, take 2

From: Jeff Dike
Date: Mon Apr 28 2008 - 13:28:39 EST


On Sat, Apr 26, 2008 at 07:22:22PM +0200, Ingo Molnar wrote:
> > It also makes me wonder why Kconfig.i386 can just include
> > arch/x86/Kconfig.cpu, but x86_64 cannot?
>
> hm, indeed arch/um/Kconfig.i386 is assymetric to Kconfig.x86_64. Jeff
> Cc:-ed.

In current git, they look pretty symmetric to me, and it boots and runs.

> arch/um/os-Linux/helper.c: In function 'run_helper':
> arch/um/os-Linux/helper.c:73: error: 'PATH_MAX' undeclared (first use in this function)
>
> it needs the patch below.

Applied, thanks.

> then it fails with:
>
> mm/filemap.c: In function '__generic_file_aio_write_nolock':
> mm/filemap.c:1831: sorry, unimplemented: inlining failed in call to
> 'generic_write_checks': function body not available

Looks like Adrian just hit that too. As Linus pointed out,
__generic_file_aio_write_nolock calls generic_write_checks at line
2383, and that's available at line 1831, which the error message
helpfully points out. I don't see how gcc can be claiming that the
function body isn't available when it's telling you exactly where it
is.

Jeff

--
Work email - jdike at linux dot intel dot com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/