Artem Bityutskiy wrote:Pekka Enberg wrote:On Mon, Apr 28, 2008 at 10:09:06AM +0300, Adrian Hunter wrote:Artem Bityutskiy wrote:
+config UBIFS_FS_DEBUG_MSG_GEN
+
+config UBIFS_FS_DEBUG_MSG_JRN
+
+config UBIFS_FS_DEBUG_MSG_CMT
+
+config UBIFS_FS_DEBUG_MSG_BUDG
+
+config UBIFS_FS_DEBUG_MSG_LOG
+
+config UBIFS_FS_DEBUG_MSG_TNC
+
+config UBIFS_FS_DEBUG_MSG_LP
+
+config UBIFS_FS_DEBUG_MSG_FIND
+
+config UBIFS_FS_DEBUG_MSG_MNT
+
+config UBIFS_FS_DEBUG_MSG_IO
+
+config UBIFS_FS_DEBUG_MSG_GC
+
+config UBIFS_FS_DEBUG_MSG_SCAN
But these don't make much sense to me. Why would you want to be able
to compile out printks at this granularity? Why not enable all of them
when CONFIG_UBIFS_FS_DEBUG is enabled?
Well, its just more convenient for us. If I know the bug is somewhere in
the journal, I enable the journal messages - less flooding. We may
lessen the amount, but it is still handy to have some classes of
prints separate.
We will think how to lessen the amount and granularity of this.
Christoph Hellwig wrote:It's everything but convenient :) Please make it one config option toSurely that judgement should be made by people who actually debug UBIFS.
compile in all debug code and then have a module option to select the
verbosity level at runtime.
I've debugged enough code including filesystems far more complex than
ubifs so you can happily trust my judgement. Even if not you can simply
switch on your brain and notice that a runtime/boottime switch is always
more convenient than a compile-time switch, and the only reason against
it would be a performance penalty.