Re: Pull request for semaphore include changes

From: Roland Dreier
Date: Wed Apr 23 2008 - 11:57:36 EST


> drivers/infiniband/core/user_mad.c | 2 +-

Let me say up front I have no problem with this change, which moved from
<asm/semaphore.h> to <linux/semaphore.h>. So take this email as an
honest question and not any form of complaint or criticism. But looking
at that user_mad.c file in particular, I don't see any use of anything
that looks like it would come from semaphore.h.

So I'm wondering why you didn't just delete the inclusion, as you did in
other places? I can merge a follow-up that does that cleanup (which
builds and works fine on my usual architectures) but I want to avoid
breaking avr32 allyesconfig or something like that.

(Commit 2fe7e6f7 "IB/umad: Simplify and fix locking" changed the locking
scheme, so maybe you looked at an older file)

Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/