Re: [2.6 patch] select ATA_SFF

From: Sergei Shtylyov
Date: Wed Apr 23 2008 - 07:17:35 EST


Jeff Garzik wrote:

Aik... We can do s/sff/tf/ and leave bmdma alone to avoid even more confusion but sff has meant tf base interface for quite some time now in libata and I think it'll be better to remember that sff is the new tf. Sorry about the mess.

This renaming was discussed at the time on lkml and linux-ide, the patches and git pushes were CC'd, and I do not recall these complaints being raised at the time.

I wasn't watching libata activity even to such a small extent that I'm doing it now, and I haven't found the discussion now.

At this point, it's too ingrained in libata. Another rename would IMO just cause more needless churn.

Well, renaming -bmdma to -sff was logical. What's not so logical is that module covering not only BMDMA activities but also taskfile access.

Jeff

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/