Re: [git pull] scheduler changes for v2.6.26

From: Peter Zijlstra
Date: Tue Apr 22 2008 - 07:11:17 EST


On Tue, 2008-04-22 at 03:49 -0700, David Miller wrote:
> From: Kevin Winchester <kjwinchester@xxxxxxxxx>
> Date: Tue, 22 Apr 2008 06:41:47 -0300
>
> > kevin@alekhine:~/linux$ ./watch-rq-clock.sh
> > 89.986517
> > 81.033471
> > 76.942776
> > 90.986318
> > 75.988551
> > 85.987089
> > 74.988696
> > 85.987078
> > 73.988858
> > 88.986641
> > 68.989600
>
> The results on my 128-cpu Niagara2 box are even more interesting:
>
> davem@maramba:~$ /bin/bash ./watch-rq-clock.sh
> 0
> 0
> 0
> 0
> 0
> 0
> 0
> 0
> 0
> 0
> 0
> 0
> 0
> ....
>
> I guess this script doesn't work correctly when the cpu
> whose clock value it greps out of /proc/sched_debug is
> in NOHZ mode?

Yeah - looking at the script it seems to look at the last one, so if
indeed that cpu is fully idle its rq clock will be stalled.

The fix that went in right after .25 was that when it came out of nohz
mode rq->clock could catch up 1 jiffy even though it had been out much
longer.

So the interesting thing to know is whether rq->clock properly accounts
for all idle time when the cpu leaves idle mode.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/