Re: [PATCH 1/2] OLPC: Add support for calling into Open Firmware

From: David Woodhouse
Date: Mon Apr 21 2008 - 16:25:59 EST


On Mon, 2008-04-21 at 15:46 -0400, Andres Salomon wrote:
> Well, no, it wasn't already working; that's the reason this whole
> thread started. It was crashing someone's machine. That's why the OFW
> interface, as imperfect as it is, is an _improvement_.

You're proposing a new interface between bootloader and kernel as a
temporary hack just to work around that until we fix it properly?

That seems like overkill to me. I'd just go for is_geode() as you
suggested, and maybe PCI configuration tricks to detect the lack of VSA
so we can be _fairly_ sure it's OLPC before we poke at it?

Or why not try '!page_is_ram(0xffffffc0 >> PAGE_SHIFT)' if it's just to
avoid that particular warning? :)

--
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/