Re: [PATCH 1/2] OLPC: Add support for calling into Open Firmware

[David Woodhouse]

On Mon, 2008-04-21 at 13:03 -0400, Andres Salomon wrote:
> Quite simply, it's a lot more work (*and* we have to play nice w/
> sparc and ppc).  

It's only more work because we did it the wrong way in the first place.
If only someone had pointed it out at the time... :)

For interaction with device-tree properties in generic code, you should
be using the functions defined in <linux/of.h>.

Creating the static device-tree before we quiesce OpenFirmware surely
shouldn't be so hard? Can't we cut and paste most of that code anyway?

> I had intended to eventually do it, but first I wanted
> to get this stuff in for 2.6.26 so that we could at least boot upstream
> kernels on XOs.

Is it only the things in your second patch which need to be made to
work? One of them was already working, by grubbing around in the BIOS
directly -- so all we need is the board revision, isn't it? Can we get
that from the EC for now?

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/