Re: Re: [PATCH]Fix usemap for DISCONTIG/FLATMEM with not-aligned zone initilaization.

[kamezawa . hiroyu]

thank you for review.

>> +		z = page_zone(page);
>
>Does this have to be recalculated for every page?  The function name
>"memmap_init_zone" suggests it could be done just once (but I'm on
>unfamiliar territory here, ignore any nonsense from me).
>
you're right. I will consider this again.

>> -		if ((pfn & (pageblock_nr_pages-1)))
>> +		if ((z->zone_start_pfn < pfn)
>
>Shouldn't that be <= ?
>
yes.

>> +		    && (pfn < z->zone_start_pfn + z->spanned_pages)
>> +		    && !(pfn & (pageblock_nr_pages-1)))
>
>Ah, that line (with the ! in) makes more sense than what was there
>before; but that's an unrelated (minor) bugfix which you ought to
>mention separately in the change comment.
>
Ah, ok. I'll rewrite and post again. thank you.

-Kame
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/