Re: [git patches] minor irq handler cleanups

[Russell King]

On Sun, Apr 20, 2008 at 09:35:51PM -0400, Jeff Garzik wrote:
> diff --git a/arch/arm/mach-integrator/time.c b/arch/arm/mach-integrator/time.c
> index 5278f58..5235f64 100644
> --- a/arch/arm/mach-integrator/time.c
> +++ b/arch/arm/mach-integrator/time.c
> @@ -125,7 +125,7 @@ static int rtc_probe(struct amba_device *dev, void *id)
>  	xtime.tv_sec = __raw_readl(rtc_base + RTC_DR);
>  
>  	ret = request_irq(dev->irq[0], arm_rtc_interrupt, IRQF_DISABLED,
> -			  "rtc-pl030", dev);
> +			  "rtc-pl030", NULL);
>  	if (ret)
>  		goto map_out;
>  

BTW, if you're removing the dev_id argument from request_irq(), that
also needs to happen for the corresponding free_irq() calls.
arch/arm/mach-integrator/time.c does:

        free_irq(dev->irq[0], dev);

and these are untouched.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/