Re: x86: 4kstacks default

From: Eric Sandeen
Date: Sun Apr 20 2008 - 10:41:00 EST


Willy Tarreau wrote:
> On Sun, Apr 20, 2008 at 09:09:37AM -0500, Eric Sandeen wrote:
>> Mark Lord wrote:
>>> Willy Tarreau wrote:
>>>> What would really help would be to have 8k stacks with the lower page
>>>> causing a fault and print a stack trace upon first access. That way,
>>>> the safe setting would still report us useful information without
>>>> putting users into trouble.
>>> ..
>>>
>>> That's the best suggestion from this thread, by far!
>>> Can you produce a patch for 2.6.26 for this?
>>> Or perhaps someone else here, with the right code familiarity, could?
>>>
>>> Some sort of CONFIG option would likely be wanted to
>>> either enable/disable this feature, of course.
>> Changing the default warning threshold is easy, it's just a #define.
>
> I thought it was checked only at a few places (eg: during irqs). If so,
> maybe it can miss some call chains ?

Ah, ok I skimmed your first suggestion too quickly. 100% coverage
reports on the initial access to the 2nd 4k that way would be nice.
Well, it would be nice if we all really wanted 4k stacks some day... :)

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/