Re: [2.6 patch] ARM: always select HAVE_IDE

From: Russell King
Date: Sat Apr 19 2008 - 07:34:44 EST


On Thu, Apr 17, 2008 at 04:25:07PM +0300, Adrian Bunk wrote:
> You have a point that one might argue that avr32 should also select
> HAVE_IDE and get an asm/ide.h .
>
> The main difference between avr32 and arm is that on arm there are a
> bunch of platforms that actually want to use drivers/ide/ at the moment,
> and the fine-grained select's we have at the moment don't bring any real
> gain.
>
> I do actually not care much how this gets resolved (we could even
> ditch HAVE_IDE and provide asm/ide.h on all architectures) if there's
> general agreement that this is the way to go.

That is probably a more correct approach.

Consider that if you do have PCMCIA, then you can plug a CF card in and,
therefore, you have an IDE interface in the system. So, selecting
HAVE_IDE if PCMCIA is enabled is entirely reasonable. What isn't so
reasonable is not providing asm/ide.h if your architecture has the
possibility of supporting PCMCIA.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/