Re: [RFC PATCH try2] sysfs: add /sys/dev/{char,block} tolookupsysfs path by major:minor

[Kay Sievers]

On Fri, 2008-04-18 at 17:41 -0700, Dan Williams wrote:
> On Fri, 2008-04-18 at 13:53 -0700, Kay Sievers wrote:
> > On Fri, 2008-04-18 at 12:33 -0700, Dan Williams wrote:
> > Also:
> >   class_create(THIS_MODULE, "usb_device");
> > in:
> >   drivers/usb/core/devio.c
> > should probably clear the dev_kobj after registration, and we can get
> > rid of the "parent has the same dev_t" logic?
> 
> Greg had suspicions that there might be more cases like
> usb_classdev_class, so I added a dev_warn() to help debug those.

Yeah, it's Linux, you never know. :) But there are no currently known
other subsystem doing this. It is perfectly ïvalid scenario though, to
have that, if someone comes up with a better idea as some current stuff
is doing it, and we need to deprecate something, and have duplicated
dev_t entries in sysfs for a while.

> I don't mind taking your word for it that there are no more such cases,
> but maybe the warning should stay in for a few -rc releases?

I think, we can remove that, as it will print a warning for the
"duplicate entry" anyway.

Looks all fine now from my point of view.

Thanks,
Kay

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/