Re: [PATCH 0/4] jbd: possible filesystem corruption fixes

From: Mingming Cao
Date: Fri Apr 18 2008 - 15:27:00 EST


On Fri, 2008-04-18 at 10:09 -0400, Josef Bacik wrote:
> On Fri, Apr 18, 2008 at 10:00:54PM +0900, Hidehiro Kawai wrote:
> > Subject: [PATCH 0/4] jbd: possible filesystem corruption fixes
> >
> > The current JBD is not sufficient for I/O error handling. It can
> > cause filesystem corruption. An example scenario:
> >
> > 1. fail to write a metadata buffer to block B in the journal
> > 2. succeed to write the commit record
> > 3. the system crashes, reboots and mount the filesystem
> > 4. in the recovery phase, succeed to read data from block B
> > 5. write back the read data to the filesystem, but it is a stale
> > metadata
> > 6. lose some files and directories!
> >
> > This scenario is a rare case, but it (temporal I/O error)
> > can occur. If we abort the journal between 1. and 2., this
> > tragedy can be avoided.
> >
> > This patch set fixes several error handling problems to protect
> > from filesystem corruption caused by I/O errors. It has been
> > done only for JBD and ext3 parts.
> >
>

Could you sent Ext4/JBD2 version patches? Thanks!

> There doesn't seem like much point in taking these patches as Jan is rewriting
> the ordered mode path and most of these functions will be going away soon.
> Those patches seem like they will be coming soon and will obsolete these.
>

I hope we have a better ordered mode very soon too. Just thought it's
still valid to fix the current ordered mode for people who uses
linux-2.6.25 kernel today.

Mingming
> Josef
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/