Re: [PATCH 3/3] Use __weak macro for smp_setup_processor_id

From: Andrew Morton
Date: Fri Apr 18 2008 - 03:07:36 EST


On Fri, 18 Apr 2008 16:56:18 +1000 Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:

> Use the __weak macro instead of the longer __attribute__ ((weak)) form
>
> Signed-off-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> --
>
> init/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-work.orig/init/main.c 2008-04-18 16:44:32.000000000 +1000
> +++ linux-work/init/main.c 2008-04-18 16:44:37.000000000 +1000
> @@ -500,7 +500,7 @@ static void __init boot_cpu_init(void)
> cpu_set(cpu, cpu_possible_map);
> }
>
> -void __init __attribute__((weak)) smp_setup_processor_id(void)
> +void __init __weak smp_setup_processor_id(void)
> {
> }

ack on all three. Please fold #3 into #1 and add both to git-powerpc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/