Re: [Suspend-devel] 2.6.25-rc6 regression - hang on resume [Bug 10319]

[Stefan Seyfried]

Romano Giannetti schrieb:
> 
> On Fri, 2008-04-04 at 08:31 +0200, Soeren Sonnenburg wrote:
>> On Fri, 2008-04-04 at 01:22 +0200, Rafael J. Wysocki wrote:
> 
>>> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10319
>>> Subject		: 2.6.25-rc6 regression - hang on resume
>>> Submitter	: Soeren Sonnenburg <kernel@xxxxxx>
>>> Date		: 2008-03-25 04:44 (10 days old)
>> Yes. The machine resumes and display stays black using s2ram -f -p
>> (blindly typing reboot etc on keyboard does what is expected). However
>> display comes back on 2.6.24.
> 
> I can add that on my laptop (toshiba U305, Intel 945GM chipset), s2ram
> -f -p -m which used to work ok, in X and console, in 2.6.24 stopped to
> work (I tested -rc8, but I think it's like that since a long time).
> Machine resumes but the screen stays off after that, although machine is
> working (exactly as Soeren said). 

can you try if this patch to libx86 (make sure it gets installed and used...)
fixes the problem?

Index: libx86-0.99/x86-common.c
===================================================================
--- libx86-0.99.orig/x86-common.c
+++ libx86-0.99/x86-common.c
@@ -232,7 +232,7 @@ int LRMI_common_init(void)
 	}

 	m = mmap((void *)0xa0000, 0x100000 - 0xa0000,
-	 PROT_READ | PROT_WRITE,
+	 PROT_READ | PROT_WRITE | PROT_EXEC,
 	 MAP_FIXED | MAP_SHARED, fd_mem, 0xa0000);

 	if (m == (void *)-1) {

> On the other hand, now the plain "echo mem > /sys/power/state" works
> perfectly, from X and console. So some of the magic vbe save/restore of
> s2ram mess something up for this card. 

Especially the userspace stuff (VBE_*) should not interfere with the restoring
now done inside the kernel drivers.

> Is it a regression for my laptop (is evidently one for Soeren)? On one
> side, a "used to work" setup is broken, but it worked with userspace
> hacks; now it works with the plain way, and that's clearly better.
-- 
Stefan Seyfried
R&D Team Mobile Devices            |              "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out."

This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/