Re: [PATCH 2/6 v2] MIPS: ip27-timer: unsigned irq to evaluateallocate_irqno()

From: Ralf Baechle
Date: Thu Apr 17 2008 - 07:00:42 EST


On Thu, Apr 17, 2008 at 12:27:56AM +0200, Thomas Bogendoerfer wrote:

> On Wed, Apr 16, 2008 at 05:09:58PM +0200, Roel Kluin wrote:
> > Thomas Bogendoerfer wrote:
> > > On Wed, Apr 16, 2008 at 03:43:56AM +0200, Roel Kluin wrote:
> > >> irq is unsigned, cast to signed to evaluate the allocate_irqno() return value,
> >
> > >> + if ((int) irq < 0)
> > >
> > > Why don't you just make irq and rt_timer_irq an int ?
> >
> > Ok, thanks, It should be right, but I cannot test this (no hardware).
>
> I've tested it on real hardware.
>
> Acked-By: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>

Thanks, applied.

Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/