Re: [2.6 patch] ARM: always select HAVE_IDE

From: Russell King
Date: Thu Apr 17 2008 - 06:08:42 EST


On Thu, Apr 17, 2008 at 12:37:53PM +0300, Adrian Bunk wrote:
> Any objections against the patch below?

Let's look at the rest of the situation surrounding HAVE_IDE first.
It's something of a mess:

avr32, m68knommu, ppc, s390 and v850 do not have asm/ide.h

avr32, m68knommu, ppc, v850 all set HAVE_IDE, arch/s390/Kconfig contains
no reference.

avr32 supports PATA (which is IDE).

Everything else provides an asm/ide.h and sets HAVE_IDE.

So:

Q1. Do avr32, m68knommu, ppc, v850 have IDE support or do they not?
Q2. Should avr32, m68knommu, ppc, v850 supply an asm/ide.h header?
Q3. Is it worth supporting HAVE_IDE for all kernel architectures when
its just one (s390) which supports neither IDE nor ATA - or would
something more generic covering both be appropriate.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/