Re: [RFC patch 23/27] Immediate Values - Powerpc Optimization NMIMCE support

[Mathieu Desnoyers]

* Paul Mackerras (paulus@xxxxxxxxx) wrote:
> Mathieu Desnoyers writes:
> 
> > Use an atomic update for immediate values.
> 
> What is meant by an "atomic" update in this context?  AFAICS you are
> using memcpy, which is not in any way guaranteed to be atomic.
> 
> Paul.

I expect memcpy to perform the copy in one memory access, given I put a 

  .align 2

before the 2 bytes instruction. It makes sure the instruction modified
fits in a single, aligned, memory write.

Or maybe am I expecting too much from memcpy ?

Mathieu

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/