Re: [PATCH 3/9] ide: add ->tf_load and ->tf_read methods

From: Bartlomiej Zolnierkiewicz
Date: Wed Apr 16 2008 - 18:29:37 EST


On Wednesday 16 April 2008, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Add ->tf_load and ->tf_read methods to ide_hwif_t and set the default
> > methods in default_hwif_transport().
>
> It's not clear to me what do we gain with addign such methods...

in short-term not much besides a nice optimization

in long-term it should enable us to remove ->IN*/OUT* methods completely

> > * Use ->tf_{load,read} instead o calling ide_tf_{load,read}() directly.
>
> > * Make ide_tf_{load,read}() static.
>
> > There should be no functional changes caused by this patch.
>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
>
> Acked-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/