Re: [PATCH][RFC] Add default CPU topology information

From: Ingo Molnar
Date: Wed Apr 16 2008 - 08:51:57 EST



* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> > This patch:
> >
> > - Adds default definitions of the 4 topology macros to
> > include/asm-generic/topology.h.
> > - Changes include/asm-*/topology.h to include <asm-generic/topology.h>
> > unconditionally.
> > - Changes drivers/base/topology.c to use the topology macros unconditionally
> > and to cope with definitions that aren't lvalues.
> > - Updates documentation accordingly.
> >
>
> I ran away in terror when I saw this patch. It's dark and dirty stuff
> you're unearthing there and it looks like a minefield of compilation
> problems. Not aided by the fact that we don't have a topology
> maintainer afaik.
>
> We shall see.

i could pick it up into sched.git - it's a frequent party to topology
patches. We've now got automated cross-build checks as well by virtue of
Thomas so common build failures ought to be rare.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/