Re: [PATCH 0/7] OMFS filesystem version 3

From: Adrian Bunk
Date: Tue Apr 15 2008 - 15:25:55 EST


On Tue, Apr 15, 2008 at 11:34:52AM -0700, Andrew Morton wrote:
> On Tue, 15 Apr 2008 12:57:27 -0400 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> > On Tue, Apr 15, 2008 at 06:16:43PM +0300, Adrian Bunk wrote:
> > > We are talking about a filesystem even Christoph considers OK.
> > >
> > > And who asked about the costs of merging crap like
> > > drivers/infiniband/hw/nes/ ?
> > >
> > > Speaking about the latter, with Linus' logic one might argue that OMFS
> > > must not be rejected since it adds support for some hardware...
> >
> > Excatly. I find it very strange to even consider rejecting a rather
> > small and very well written driver for let's say "political" reasons.
>
> "economic" would be a far more accurate term.
>
> Look, I have repeatedly described the reason why it is probable a poor
> tradeoff to merge code such as this. The only response has been "well
> we've done it before", which is largely a non-reason.
>...

It seems you missed the first point in my email:

We do not have a stable API for external modules, and part of the deal
is that external modules have the chance of entering the kernel where
they will get API changes automatically.


Plus my other point that one might argue that OMFS adds support for some
hardware in which case a recent commandment by Linus would require it
has to be merged...


cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/