Re: pci: add to global list before sysfs?

From: Greg KH
Date: Tue Apr 15 2008 - 15:20:37 EST


On Mon, Apr 14, 2008 at 07:35:38AM +1000, Benjamin Herrenschmidt wrote:
>
> On Fri, 2008-04-04 at 14:01 -0700, Greg KH wrote:
> > As I mention above, the "global list" is now gone, so it's going to be
> > a
> > bit harder to do this. We now only keep one list of all PCI devices,
> > and that is with the driver core mechanisms as the duplicate list was
> > just sitting there doing nothing for the past 4 years.
> >
> > So is the problem that your driver need to bind to multiple pci
> > devices
> > at the same time in order to work properly?
> >
> > Or is this just really broken hardware?
>
> Haven't had a chance to look at your changes yet, but I have memories of
> being pretty happy with having that 2 step mechanism in PCI where the
> driver core would only see the devices after fixup.

No, that is left alone, I just dropped the duplicate device list that
was linked within the PCI devices themselves. The only user of it was
the "reorder the PCI devices" code for some Dell machines, and that was
just doing it to be safe (it was also reordering the driver core list of
PCI devices, which is what really mattered.)

So everything should still be fine.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/