Re: [PATCH 0/7] OMFS filesystem version 3

From: Andrew Morton
Date: Tue Apr 15 2008 - 14:36:30 EST


On Tue, 15 Apr 2008 12:57:27 -0400 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> On Tue, Apr 15, 2008 at 06:16:43PM +0300, Adrian Bunk wrote:
> > We are talking about a filesystem even Christoph considers OK.
> >
> > And who asked about the costs of merging crap like
> > drivers/infiniband/hw/nes/ ?
> >
> > Speaking about the latter, with Linus' logic one might argue that OMFS
> > must not be rejected since it adds support for some hardware...
>
> Excatly. I find it very strange to even consider rejecting a rather
> small and very well written driver for let's say "political" reasons.

"economic" would be a far more accurate term.

Look, I have repeatedly described the reason why it is probable a poor
tradeoff to merge code such as this. The only response has been "well
we've done it before", which is largely a non-reason.

You can continue to ignore my logic, but that won't go unnoticed.

Just as a thought exercise: should we merge a small and well-written
driver which has zero users?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/