Re: [PATCH 4/8] rfkill: add read-write rfkill switch support

From: Dmitry Torokhov
Date: Tue Apr 15 2008 - 08:59:12 EST


On Tue, Apr 15, 2008 at 08:27:49AM +0100, Carlos Corbacho wrote:
> On Monday 14 April 2008 21:23:14 Dmitry Torokhov wrote:
> > On Mon, Apr 14, 2008 at 08:06:50PM +0100, Carlos Corbacho wrote:
> > > I agree wholeheartedly with Henrique here though - wireless drivers
> > > should _not_ be using key press events as a reporting mechanism.
> >
> > Reporting mechanism for what exacly though? Depending on what you are
> > talking about we either agree or disagree here ;)
>
> Reporting state change in this case. For instance, KEY_WLAN means exactly
> that - a user pressed a key that was mapped to KEY_WLAN. It's not a generic
> notifier for any and all wireless events, state changes, etc.
>
> If wireless drivers want to report a state change, then we need a proper
> mechanism for that, as has already been discussed by Henrique.
>

I think everyone is in a violent agreement here but prefers to keep
talking to appear that they not agree ;)

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/