Re: [2.6 patch] add include/asm-avr32/xor.h

From: Dan Williams
Date: Mon Apr 14 2008 - 19:46:18 EST


On Mon, Apr 14, 2008 at 3:30 PM, Mike Frysinger <vapier.adi@xxxxxxxxx> wrote:
> On Mon, Apr 14, 2008 at 6:27 PM, Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
> > "arches" did not have to go through and figure out the fun little stub
> > file for xor.h. Adrian already made your "life easier".
>
> actually he didnt. he posted a fix for avr32. i dont care about
> avr32, i'm a blackfin guy. he also wouldnt have had to do anything at
> all if everything was handled with indirection in linux/xor.h.
>
> your point also is irrelevant in the case of new architectures. poor
> microblaze for example.
>

Don't get me wrong I see the pain-reducing-value in codifying all the
features that have architecture specific aspects with HAVE_* config
variables. But in this case I think a 6 line patch per new arch gets
the immediate job done.

Regards,
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/