Re: [PATCH-mm 11/15] video: Use get/put_unaligned_* helpers

[Harvey Harrison]

On Tue, 2008-04-15 at 00:05 +0100, Al Viro wrote:
> On Mon, Apr 14, 2008 at 03:48:00PM -0700, Harvey Harrison wrote:
> > Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> > ---
> >  drivers/video/matrox/matroxfb_misc.c |   28 ++++++++++++++--------------
> >  drivers/video/metronomefb.c          |    9 +++------
> >  2 files changed, 17 insertions(+), 20 deletions(-)
> > 
> > diff --git a/drivers/video/matrox/matroxfb_misc.c b/drivers/video/matrox/matroxfb_misc.c
> > index ab7fb50..cfb5205 100644
> > --- a/drivers/video/matrox/matroxfb_misc.c
> > +++ b/drivers/video/matrox/matroxfb_misc.c
> > @@ -522,8 +522,6 @@ static void parse_bios(unsigned char __iomem* vbios, struct matrox_bios* bd) {
> >  #endif
> >  }
> >  
> > -#define get_u16(x) (le16_to_cpu(get_unaligned((__u16*)(x))))
> > -#define get_u32(x) (le32_to_cpu(get_unaligned((__u32*)(x))))
> 
> Why not simply change definitions of those?

Could have done, but seeing the number of times it was used in the file
and what the code looked like with it simply replaced, I went for
eliminating the macro.

If you'd prefer a two-patch, replace in macro/replace macro entirely
I could do so.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/