Re: [PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks (rev. 8)

From: Oliver Neukum
Date: Mon Apr 14 2008 - 16:41:53 EST


Am Montag, 14. April 2008 16:49:26 schrieb Alan Stern:
> Now, I don't see what the big deal is here.  We all agree that it would
> be nice and appropriate if drivers could do things like
> request_firmware() during prepare().  But for the moment they can't.  
> It's not like this is some tremendous hardship -- you aren't going to
> have to rip out all the existing prepare() implementations and rewrite
> them, because they don't exist yet!

True. You cannot request firmware in the current suspend() call either.
Rafael's code is a clear improvement over the existing code. Removal
of the freezer will need a lot of rewriting in any case.

Regards
Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/