Re: [Fwd: [-mm] Add an owner to the mm_struct (v9)]

From: Andrew Morton
Date: Mon Apr 14 2008 - 15:42:28 EST


On Mon, 14 Apr 2008 09:04:28 -0700
"Paul Menage" <menage@xxxxxxxxxx> wrote:

> On Mon, Apr 14, 2008 at 7:49 AM, Pekka Enberg <penberg@xxxxxxxxxxxxxx> wrote:
> > Balbir Singh wrote:
> >
> > > If nobody has any specific objection to this patch, can I go ahead and
> > request
> > > Andrew to include this patch?
> > >
> >
> > ->owner in struct mm_struct is very useful for revokeat() so
> >
> > Acked-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
> >
>
> Reviewed-by: Paul Menage <menage@xxxxxxxxxx>
>
> I'm still not sure when to use Acked-by versus Reviewed-by - is it
> just based on the level of scrutiny/review?
>

Yes. Reviewed-by: is a lot stronger that Acked-by:. I've seen some pretty
shocking Acked-by:'s :)

Documentation/SubmittingPatches goes into a surprising amount of detail.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/