Re: [Patch] arch/um/os-Linux/sys-i386/task_size.c: improve a bit

From: Jeff Dike
Date: Mon Apr 14 2008 - 11:00:43 EST


On Sat, Apr 12, 2008 at 05:17:47PM +0800, WANG Cong wrote:
> Improve this code a bit: check sigaction's return value and remove a useless
> fflush().

This looks fine. BTW, some of the fflushing is on purpose, although
the one you removed does indeed look useless. I want all output from
early boot to hit the screen as soon as possible, even in the absence
(so far) of a newline. So, if there's any doubt about whether a
printf has a newline in it, it's flushed.

Jeff

--
Work email - jdike at linux dot intel dot com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/