Re: [PATCH] x86: pgtable_32.h - prototype and section mismatchfixes

From: Ingo Molnar
Date: Mon Apr 14 2008 - 03:27:23 EST



* Jacek Luczak <difrost.kernel@xxxxxxxxx> wrote:

> paravirt_pagetable_setup_[start,done]() is used by __init
> pagetable_init(). Annotate both functions with __init.

> #ifndef CONFIG_PARAVIRT
> -static inline void paravirt_pagetable_setup_start(pgd_t *base)
> +static inline void __init paravirt_pagetable_setup_start(pgd_t *base)
> {
> native_pagetable_setup_start(base);
> }

hm, that's an interesting case: we need those annotations probably
because gcc decided to not inline those functions. (this is possible via
the new CONFIG_OPTIMIZE_INLINING=y option) Sam, what's your take on
that?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/