Re: [PATCH 1/3] PM: Introduce new top level suspend andhibernation callbacks (rev. 8)

From: Benjamin Herrenschmidt
Date: Sun Apr 13 2008 - 23:24:34 EST



> To avoid breaking things (from the functional point of view) unnecessarily.
>
> In short, I don't really see the difference between moving ->prepare() before
> the freezer and droppig the freezer, which I'm not going to do right now.

I believe the use of prepare for things like request_firmware etc... is
worth the effort of fixing the known breakage of not having the freezer
while preventing insertion of new devices (mostly USB). In fact, it
won't be such a big issue as the core should/will return an error from
attempting to add the device in that case.

Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/