Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC

From: Alan Cox
Date: Sat Apr 12 2008 - 07:04:53 EST


On Sat, 12 Apr 2008 10:10:40 +0200
Krzysztof Halasa <khc@xxxxxxxxx> wrote:

> Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> writes:
>
> > It never hurts to resend. It was 6000 patches ago and my mind is a blank.
>
> Sure, here is it. Some description, well:
>
> PPP support in generic HDLC in Linux 2.6.25 is broken and will cause
> a kernel panic when a device configured in PPP mode is activated.
>
> It will be replaced by new PPP implementation after Linux 2.6.25 is
> released.

Thats a pretty bad regression. Surely the correct fix is to revert the
change series that caused the breakage then re-merge that and fixes for
HDLC PPP for 2.6.26, not just leave it broken ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/