Re: [PATCH] Replace completions with semaphores

From: Ingo Oeser
Date: Sat Apr 12 2008 - 06:33:43 EST


Hi Daniel,

On Saturday 12 April 2008, Daniel Walker wrote:
> From my perspective it should be keep completions , and remove
> semaphores.. The problem with semaphores is the lack of a strict API,
> and loose usage.

Seconded!

Ask any software engineer, to describe what a semaphore is and
how it behaves. You'll get the full spectrum of possible semaphore
implementation options. Ask any advanced software engineer and he'll
ask "What kind of semaphore?".

So let them die ASAP!

> At times I've spent hours trying to figure out what a semaphore
> is doing, or suppose to be doing.

Same here. Or figuring out what kind of semphore behavior the developer
expected.

> If we enforce strict usage of semaphores, then we'll basically reproduce
> mutex usage, and we have a generic mutex already..

Or have different API for using the same semaphores in different
creative ways. It might be hard to implement lockdep for that :-)

No, I'm happy that Linux has so many more advanced concurrency concepts,
that the pre-dinosaur locking mechanism (semaphore) is usually
the last on your list.


Best Regards

Ingo Oeser
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/