Re: BUG: using smp_processor_id() during suspend with 2.6.25-rc8

From: Rafael J. Wysocki
Date: Fri Apr 11 2008 - 11:27:36 EST


On Friday, 11 of April 2008, Andi Kleen wrote:
> > thanks Pavel, i picked this up into sched-devel.git - it makes sense
> > independently of whether it solves the warning.
>
> This means the CPU preempt sanity checking is effectively disabled
> on UP kernels. Even though more and more people should run multi-core
> now there is still a sizeable user base left on single core.
>
> Don't think this is a good idea. We need even the UP testers.

Agreed.

Besides, I'd like to learn what caused the problem to appear in the first
place.

> If he wants this for suspend or machine check/oops (always useful there
> to disable such warnings) then there should
> be separate checks for this. Perhaps system_state could be enhanced for this?

That would make sense.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/