Re: [PATCH 5/6] Clocklib: Use correct clock for IrDA on pxa

From: Dmitry
Date: Wed Apr 09 2008 - 15:39:25 EST


Hi, Russell,

2008/4/9, Russell King <rmk+lkml@xxxxxxxxxxxxxxxx>:
> On Wed, Apr 09, 2008 at 08:09:16PM +0100, Alan Cox wrote:
> > > Basically what I'm thinking is a serial_core function which could be
> > > called to say "I'm an IrDA driver, and I think I should be using the
> > > serial port located <here>, please give me control of it" and it'd
> > > pass over the various parameters including the struct device for it.
> > > Or something like that.
> >
> > It's called a line discipline, we've had them for many years. We may need
> > a way for ldiscs and drivers to co-operate a bit more but these days we
> > support proper buffering and arbitary baud rates (except on a few
> > platforms whose maintainers are not paying attention ;)).

That would be a good thing to have.

> I feel that's a "it would be nice if" solution - and something worth
> aiming for, but the amount of work required to get there is not going
> to be insignificant.
>
> Maybe Dmitry can bite his nails on the NULL device clklib issue for a
> while as this transition is happening ? (Though we need to find someone
> to make it happen... we need volunteers!)

Russell, I'd propose to agree to bind PXA's IrDA to STUARTCLK and
leave UARTCLK function to real pxa uart driver. If you would oppose, I
won't have any choises other that to agree with it.

--
With best wishes
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/